fix: skip PASS-verdict reviews in roborev fix#382
Merged
Conversation
Reviews that passed (verdict "P") have no findings to fix. Both fixSingleJob and runFixBatch now check the verdict before invoking an agent, matching the behavior already present in refine's findFailedReviewForBranch. Passing reviews are auto-marked as addressed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…IDs in test Address review feedback: the batch PASS-skip path silently discarded markJobAddressed errors, inconsistent with fixSingleJob and the later batch marking logic. Also strengthen TestFixBatchSkipsPassVerdict to assert that job 10 is actually marked addressed by recording posted job_id values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined Review (
|
The test-pass-skip agent registered in TestFixSingleJobSkipsPassVerdict leaked into TestSelectRefineAgentCodexFallback, causing it to find an agent when it expects none. Add t.Cleanup to unregister after the test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roborev fixnow skips reviews with a PASS verdict instead of wastefully invoking an agent on them, matching the existing behavior inroborev refinefixSingleJobandrunFixBatchcheck the verdict (stored or parsed from review output) and auto-mark passing jobs as addressedjobVerdicthelper that usesjob.Verdictwhen populated, falling back tostorage.ParseVerdict(review.Output)Closes #372
Test plan
TestJobVerdict— table-driven: stored P/F, nil fallback, empty fallbackTestFixSingleJobSkipsPassVerdict— PASS review returns nil without agent invocation, job marked addressedTestFixBatchSkipsPassVerdict— mixed PASS/FAIL batch: only FAIL job reaches agent, PASS job marked addressed (asserted by recorded job_id)go test -race ./cmd/roborev -count=1— all existing fix tests pass🤖 Generated with Claude Code